change: Add image configs and region config for TPE (ap-east-2) #5167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-davidson
approved these changes
May 9, 2025
chad119
previously approved these changes
May 9, 2025
varunmoris
reviewed
May 12, 2025
| "versions": { | ||
| "0.29.0": { | ||
| "registries": { | ||
| "ap-east-2": "975050140332", |
Contributor
There was a problem hiding this comment.
are we sure neuronx is regionalized here? We had this issue before where we are adding regions that don't contain the images
Contributor
There was a problem hiding this comment.
This should be fixed in the regionalizer, otherwise this will block new regions.
Contributor
There was a problem hiding this comment.
Neuronx has a specific regionalization process that we own. We own the region list that neuronx will be regionalized to. If that did not update, we should not update this as customers would expect the image to be in that region when it isn't
IshaChid76
had a problem deploying
to
manual-approval
GitHub Actions
Error
IshaChid76
had a problem deploying
to
manual-approval
GitHub Actions
Error
IshaChid76
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
chad119
approved these changes
May 12, 2025
IshaChid76
had a problem deploying
to
manual-approval
GitHub Actions
Error
IshaChid76
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
HollowTube
pushed a commit
to HollowTube/sagemaker-python-sdk
that referenced
this pull request
Jul 15, 2025
…5167) * add image configs and region config for TPE (ap-east-2) * remove TPE from djl-neuronx --------- Co-authored-by: isha chidrawar <[email protected]> Co-authored-by: pintaoz-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.